Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all the non react components code to typescript #847

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 20, 2023

This completes the migration to typescript of all the non react components code.
The only changes introduced besides types are the type checks using "something" in object which narrows down types in typescript.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6d8ee0d:

Sandbox Source
maputnik Configuration

Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@HarelM HarelM merged commit 3bf0e51 into maplibre:main Dec 20, 2023
8 checks passed
@HarelM HarelM deleted the typescript2 branch December 20, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants